chore: [NOJIRA] merge in changes from parent repo#4
Open
MatthewRyanRead wants to merge 7 commits into
Open
Conversation
* Bug fix for resources with bidirectional dependancies * updated cached resource to include type, wrote test for bidirectional relationships * making cache value a set of ids * should be checking should load of resource in inner loop * using set literal and no need for nil coalescing * renamed signature for caching resources * keeping cached resource contained in method so client does not need to implement their own empty cache
* Migrate to Swift 5 * Cleanup some warnings * Updated Pod Spec with swift version 5.0 * Updating travis CI * Updating simulator runtime to iOS 12.2
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project to Swift 5.0 and Xcode 10.2, adds Swift Package Manager support via Package.swift, and resolves an infinite recursion issue when loading bidirectional relationships in JSONAPIResource by introducing a caching mechanism. It also updates Travis CI configuration, refactors unit tests to support SPM, and adds a test case for bidirectional relationships. I have no further feedback to provide.
djpearce
approved these changes
Jul 8, 2026
mlevinrtr
approved these changes
Jul 8, 2026
fmasutti
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.