feat(split): make Smart Money Split sliders interactive with live 100…#506
Open
midexol wants to merge 1 commit into
Open
feat(split): make Smart Money Split sliders interactive with live 100…#506midexol wants to merge 1 commit into
midexol wants to merge 1 commit into
Conversation
…% validation Closes Remitwise-Org#457 - Convert SplitConfiguration to manage allocation state via useState, initialized from DEFAULT_SPLIT_CONFIG (spending 50, savings 30, bills 15, insurance 5) - Remove disabled attribute from all four range sliders; add onChange handler and controlled number input per slider for keyboard access - Live total computed inline; validatePercentages() called on every change via useMemo - Total card colour-codes green (100%), amber (under), red (over) with aria-live region for screen-reader announcements - Inline validation message shown under total when sum != 100 - Submit button (Save Allocation) disabled and aria-disabled while total != 100 or submission is pending - AsyncSubmissionStatus wired to real pending/success/error state; idle copy reflects current validation result - Loader2 spinner shown in button during pending state - Full keyboard + aria-valuetext accessibility on sliders - Add tests/unit/split/split-config.test.ts covering validatePercentages, computeAllocation, DEFAULT_SPLIT_CONFIG, and submit-button gating logic Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #457