feat(format): add locale-aware currency formatter and apply to receipt#505
Open
umohjosephemmanuel-cyber wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLOSES #467
Description
Amounts were formatted ad hoc across the app — raw numbers in
TransactionSuccessReceipt.tsx, inline arithmetic in app/send/page.tsx, and
split percentages in CurrentMoneySplitWidget.tsx. This PR introduces a single
formatCurrency/formatAmount utility and applies it consistently across all
high-visibility financial surfaces.
Inconsistent number formatting (decimals, thousands separators, currency
symbols) on a financial product erodes trust and breaks for non-US locales.
──────────────────────────────────────────────────────────────────────────────
Changes
options) utility using Intl.NumberFormat, with graceful fallback (1,234.50
USDC) for stablecoin codes that Intl does not recognize
negative values, zero, USDC stablecoin fallback, es-ES locale separators, and
formatAmount alias
displayed amounts
percentages/amounts
formatter to send flow breakdown