Feat/family spending limits#498
Open
ekwe7 wants to merge 3 commits into
Open
Conversation
Implements the Add/Edit Savings Goal flow by lifting goalsData into
component state and providing a fully accessible modal form.
Key changes:
- Integrated lib/validation/savings-goals for real-time form validation.
- Externalized all strings and error messages to en.json for full i18n
support.
- Implemented modal accessibility (focus trap, ESC to close, and
motion-reduce).
- Recomputed daysLeft and isOverdue dynamically from the target date.
- Added 100% test coverage for goals utilities and validation logic.
- Improved UI robustness with line-clamping for long titles and descriptions
… reflection Cleans up unrelated syntax errors, missing imports, and type issues in app/ and components/ to ensure a green CI build for the savings goals feature.
Adds set/edit limit control and a spent-vs-limit progress bar with near/over-limit warning states. Includes validation logic for spending limits and improves accessibility of the utilization display.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #472
Description
per-member spending limits in the Family Wallets dashboard.
Changes
Validation: Added
lib/validation/family-limits.tstoensure spending limits are non-negative, finite numbers.
UI/UX:
Updated
FamilyMemberStatCardto include an edit mode forspending limits.
Integrated the utilization progress bar using the existing
visual pattern and updated it with accessibility roles
(
aria-valuenow,role="progressbar").Added warning states to reflect near-limit and over-limit
conditions.
Testing: Added unit tests in
tests/unit/validation/family-limits.test.tsto verify thevalidation utility.
Testing
for spending limits.