feat: bench get_schedules_paginated and verify cursor monotonicity#796
Merged
Conversation
Contributor
|
gas benchmarks plus a cursor-monotonicity check on get_schedules_paginated - exactly the kind of perf + correctness guard we want on the paginated query paths. merging 👍 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #777
Description
This PR adds performance benchmarks and correctness tests for
RemittanceSplit::get_schedules_paginated, ensuring schedule pagination remains efficient and behaves correctly at scale.Since schedule listing is frequently used by clients polling upcoming remittances, these additions help guarantee that gas consumption stays bounded as cursor positions advance and that pagination terminates without duplicates or missing entries.
Gas Benchmarks
Added gas benchmarks for
get_schedules_paginatedwith:MAX_SCHEDULES_PER_OWNER(50 schedules)Verified that per-page gas cost remains bounded as the cursor advances.
Pagination Correctness Tests
Added tests to ensure:
Edge Cases Covered
MAX_SCHEDULES_PER_OWNERschedules.Documentation
SCHEDULE_GAS_BENCHMARKS_SUMMARY.mdwith benchmark results.