Test/reporting topn deterministic ordering#794
Merged
Baskarayelu merged 2 commits intoJun 19, 2026
Merged
Conversation
Contributor
|
deterministic ordering + tie-break for the top-N reports removes a real source of flaky output. merging 👍 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deterministic Top-N ordering is implemented and documented.
Changes made:
reporting/src/lib.rs
get_top_bills_report: deterministic order = amount desc, tie-break id asc.
get_top_savings_report: deterministic order = target_amount desc, tie-break id asc.
Fixed a mis-indentation issue that could nest TopNBillsReport under a previous item.
docs/top-n-report-ordering.md
Documents the Top-N sorting + tie-break contract and cap/partial semantics.
reporting/src/tests.rs
Added mocks BillsTieAllEqual and SavingsTieAllEqual plus tests:
test_top_n_reports_tie_break_is_deterministic_bills
test_top_n_reports_tie_break_is_deterministic_savings
These assert deterministic ordering across repeated calls and correct tie-break when all amounts/targets are equal.
closes #761