refactor(insurance): return typed InsuranceError instead of panicking#749
Merged
Baskarayelu merged 1 commit intoJun 18, 2026
Merged
Conversation
Contributor
|
yes, swapping the panics in create_policy/pay_premium for typed InsuranceError is exactly the hardening insurance needed. clean diff. merging. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #712
Summary
Refactored the insurance contract to return typed
InsuranceErrorinstead of panicking, aligning it with the workspace error-handling convention used by other contracts (RemittanceSplitError, SavingsGoalError, BillPaymentsError).Changes
Converted all public functions to return
Result<T, InsuranceError>:Converted internal helpers to return
Result:Mapped all panics to existing
InsuranceErrorvariants:InvalidNameInvalidPremiumInvalidCoverageAmountUnsupportedCombinationInvalidExternalRefMaxPoliciesReachedPolicyNotFoundPolicyInactiveUnauthorizedNotInitializedAlreadyInitializedAdded Rust doc comments documenting which errors each public function can return
Updated tests to handle
Resulttypes with.unwrap()Why This Matters
Panics abort transactions with opaque host errors, preventing callers (CLI, indexer, orchestrator cross-contract flows) from distinguishing recoverable validation failures from real faults. Typed errors are the contract's public ABI for failure — the insurance contract was the only one missing this.
Acceptance Criteria
panic!,unwrap(), orexpect()in non-test insurance codeInsuranceErrorvariant is reachableResulttypes