test(insurance,reporting): coverage_to_premium ratio guard + report t… (#736)#745
Merged
Baskarayelu merged 1 commit intoJun 18, 2026
Merged
Conversation
…ests (Remitwise-Org#736) Pins the on-create ratio boundary and the downstream coverage_to_premium_ratio computation in get_insurance_report.
Contributor
|
good call covering the weakest-tested crate - the coverage_to_premium ratio guard plus the report-side assertion close a real gap on insurance. merging 👍 |
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces boundary tests for the
coverage_to_premiumratio logic to ensure that nonsensical policies are blocked on creation and that the ratio is accurately reported downstream.Fixes #736
Changes Included
insurance/tests/ratio_guard.rs):coverage_amount == premium * 12 * 500but strictly rejects+1with anUnsupportedCombinationerror.reporting/tests/insurance_report_ratio.rs):get_insurance_report.coverage_to_premium_ratiois correctly computed using checked math to prevent division-by-zero errors.annual_premiumcorrectly aggregates asmonthly_premium * 12.Context & Notes
#![no_std]environment.cargo test -p insuranceandcargo test -p reporting.