proxy: normalize wrapped Loki responses when resultType is missing#222
Merged
proxy: normalize wrapped Loki responses when resultType is missing#222
Conversation
Contributor
PR Quality ReportCompared against base branch Coverage and tests
Compatibility
Compatibility components
Performance smokeLower CPU cost (
State
|
# Conflicts: # CHANGELOG.md
5472cfa to
c0cf92a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes intermittent Grafana Loki datasource failures reporting
no resultType foundin Logs Drilldown.Root cause was
wrapAsLokiResponsepassing backend payloads through even whendata.resultTypewas missing (or when payloads used top-levelresults). Grafana's Loki plugin then failed to decode those responses.Changes
data.resultType(fallback from call context)data.resultexists (fallback empty array)resultsinto Lokiresultwhile keeping legacyresultsfor compatibilityValidation
go test ./internal/proxy -count=1error: no resultType foundfrom plugin