Skip to content

fix(chart): quote rendered helm args#221

Merged
szibis merged 2 commits intomainfrom
ss/quote-chart-args
Apr 20, 2026
Merged

fix(chart): quote rendered helm args#221
szibis merged 2 commits intomainfrom
ss/quote-chart-args

Conversation

@szibis
Copy link
Copy Markdown
Collaborator

@szibis szibis commented Apr 20, 2026

Summary

  • quote rendered chart args in
  • prevent YAML breakage when extraArgs or observability-derived args contain JSON or other special characters
  • add a CI regression render covering quoted args like and

Validation

  • WARNING: both 'platformCommand' and 'command' are set in "/Users/slawomirskowron/Library/helm/plugins/helm-secrets/plugin.yaml" (this will become an error in a future Helm version)
    WARNING: both 'platformCommand' and 'command' are set in "/Users/slawomirskowron/Library/helm/plugins/helm-secrets/plugin.yaml" (this will become an error in a future Helm version)
    ==> Linting charts/loki-vl-proxy
    Error unable to check Chart.yaml file in chart: stat charts/loki-vl-proxy/Chart.yaml: no such file or directory

Why

The current chart emits raw arg strings, which breaks manifest rendering for JSON-valued args used downstream in real deployments.

@github-actions github-actions Bot added size/M Medium change scope/helm Helm chart scope/ci CI/CD bugfix Bug fix labels Apr 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

PR Quality Report

Compared against base branch main.

Coverage and tests

Signal Base PR Delta
Test count 1807 1807 0
Coverage 89.3% 89.3% 0.0% (stable)

Compatibility

Track Base PR Delta
Loki API 100.0% 11/11 (100.0%) 0.0% (stable)
Logs Drilldown 100.0% 17/17 (100.0%) 0.0% (stable)
VictoriaLogs 100.0% 11/11 (100.0%) 0.0% (stable)

Compatibility components

Track Component Base PR Delta
Loki API label_values 2/2 (100.0%) 2/2 (100.0%) 0.0% (stable)
Loki API labels 4/4 (100.0%) 4/4 (100.0%) 0.0% (stable)
Loki API metrics 2/2 (100.0%) 2/2 (100.0%) 0.0% (stable)
Loki API otel 1/1 (100.0%) 1/1 (100.0%) 0.0% (stable)
Loki API query_range 1/1 (100.0%) 1/1 (100.0%) 0.0% (stable)
Loki API series 1/1 (100.0%) 1/1 (100.0%) 0.0% (stable)
Logs Drilldown detected_fields 11/11 (100.0%) 11/11 (100.0%) 0.0% (stable)
Logs Drilldown label_values 1/1 (100.0%) 1/1 (100.0%) 0.0% (stable)
Logs Drilldown level_volume 2/2 (100.0%) 2/2 (100.0%) 0.0% (stable)
Logs Drilldown patterns 1/1 (100.0%) 1/1 (100.0%) 0.0% (stable)
Logs Drilldown service_logs 1/1 (100.0%) 1/1 (100.0%) 0.0% (stable)
Logs Drilldown service_selection 1/1 (100.0%) 1/1 (100.0%) 0.0% (stable)
VictoriaLogs detected_fields 4/4 (100.0%) 4/4 (100.0%) 0.0% (stable)
VictoriaLogs field_values 3/3 (100.0%) 3/3 (100.0%) 0.0% (stable)
VictoriaLogs index_stats 1/1 (100.0%) 1/1 (100.0%) 0.0% (stable)
VictoriaLogs stream_translation 1/1 (100.0%) 1/1 (100.0%) 0.0% (stable)
VictoriaLogs synthetic_labels 1/1 (100.0%) 1/1 (100.0%) 0.0% (stable)
VictoriaLogs volume_range 1/1 (100.0%) 1/1 (100.0%) 0.0% (stable)

Performance smoke

Performance smoke was skipped for this PR because no perf-sensitive paths changed.

State

  • Coverage, compatibility, and sampled performance are reported here from the same PR workflow.
  • This is a delta report, not a release gate by itself. Required checks still decide merge safety.
  • Performance smoke was intentionally skipped because no perf-sensitive paths changed in this PR.
  • Delta states use the same noise guards as the quality gate (percent + absolute + low-baseline checks), so report labels match merge-gate behavior.

@github-actions github-actions Bot added size/M Medium change scope/docs Documentation and removed size/M Medium change labels Apr 20, 2026
@szibis szibis merged commit 6f3c09c into main Apr 20, 2026
44 checks passed
@szibis szibis deleted the ss/quote-chart-args branch April 20, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bug fix scope/ci CI/CD scope/docs Documentation scope/helm Helm chart size/M Medium change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant