new: lithostitched support (non-ocl subprojects)#571
Conversation
…feature/litho-integration
|
Thanks for the PR. However the project currently don't accept contributions to the OpenCL subproject due to licensing until we figure out how to properly accept contributions to it. And I would like to change how codegen works inside that subproject at some point as well. Other changes seems good from the first glance. A few problems:
I think compatibility with lithostitched should ideally be provided by C2ME, since there's currently no stable API, and providing a stable API for a compiler backend isn't trivial. |
|
Thanks for the feedback and update. Regarding OCL accel: Haven't decided yet, but I'll either keep the changes and wait, or split that subproject into a later PR once licensing is figured out and contributions open. I'll go ahead and fix the guarding. For integrations handling, I may use a CodeGenRegistry & emitters (slight refactor to generalize the emitters to support dfs -> ast nodes) for now. I won't touch that any further until I see how you refactor it. I don't expect this to be done for quite a while. |
|
Narrowing the scope of this PR to non-OpenCL subprojects. At some point, I'll split those changes into another draft PR that can stay open until licensing is figured out. |
ebo2022
changed the title
…feature/litho-integration # Conflicts: # c2me-opts-dfc/src/main/java/com/ishland/c2me/opts/dfc/common/ast/opto/passes/FoldConstants.java
This reverts commit 98d23e3.
…-integration # Conflicts: # c2me-opts-dfc/src/main/java/com/ishland/c2me/opts/dfc/common/ast/McToAst.java
2 participants
This pull request currently adds AST conversion and bytecode/dot/OCL emitters for all Lithostitched dfs except
FastNoiseDensityFunction. Eventually, it will also include natives accel forFastNoiseDensityFunction(using the C port of FastNoiseLite) and OpenCL accel support for the region system & biome injectors.Leaving as a draft while I work on this. Please let me know if I should keep this as a separate addon, or if it's better fit to implement on Lithostitched's side. Otherwise, I'll keep this here for feedback; once done, I'll convert to a regular PR and provide benchmarks + compat tests.