Repository navigation
Conversation
This was referenced Aug 23, 2026
Owner
Author
|
Superseded by consolidated Draft PR #23. The PowerShell 5.1 form-POST fix and regression coverage are included there so release hardening has one review/validation surface. This PR is being closed without merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A real Windows PowerShell 5.1 E2E build on 2026-08-23 reached the new fresh UUP conversion-package download, then failed before the HTTP request was sent:
Не удается найти перегрузку для "FormUrlEncodedContent" и количества аргументов: "5".The Direct network path calls
Invoke-WibHttpRequestCore, which built aList<KeyValuePair<string,string>>and passed it through positionalNew-Object Net.Http.FormUrlEncodedContent($pairs). Windows PowerShell 5.1 enumerates that list and treats the five form entries as five constructor arguments instead of oneIEnumerable<KeyValuePair<string,string>>argument.Fix
-ArgumentListelement with the unary comma;Invoke-WibHttpRequestCoreform-content construction, preserving the existing Network Policy, proxy behavior, HTTP status handling, downloads and error taxonomy;Network.ps1implementation;Regression coverage
tests/NetworkPowerShell51Compat.Tests.ps1verifies:Network.ps1;System.Net.Http.FormUrlEncodedContentobject instead of a five-argument constructor call;Release status
This is a second release-blocker hotfix discovered by the first real E2E run after PR #15 was merged. Keep this PR Draft until Windows self-hosted validation passes and the real ISO E2E is rerun successfully.