Security: Add zero-byte config data rejection#12
Merged
Conversation
Implement comprehensive zero-byte protobuf rejection across all config loading mechanisms to prevent potential security issues from malformed data: Security Features: - Reject zero-byte config data from HTTP responses with IllegalArgumentException - Reject zero-byte config data from cache with IllegalArgumentException - Ignore zero-byte config data from SSE streams with warning logs - Exceptions trigger internal retry logic without propagating to embedding applications Implementation Details: - HttpClient: Added zero-byte validation in requestConfigsFromURI() for HTTP responses and cached data - SseConfigStreamingSubscriber: Added zero-byte detection in FlowSubscriber.onNext() for SSE streams - All rejections logged with appropriate warning messages for debugging Test Coverage: - 4 new HttpClient tests covering zero-byte rejection from HTTP responses, cache, and valid config processing - 5 new SseConfigStreamingSubscriber tests covering zero-byte SSE data, empty payloads, and valid processing - Fixed existing tests to use valid non-zero protobuf data instead of empty default instances 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements comprehensive zero-byte protobuf rejection across all config loading mechanisms to prevent potential security issues from malformed data.
Security Features
IllegalArgumentExceptionIllegalArgumentExceptionImplementation Details
requestConfigsFromURI()for HTTP responses and cached dataFlowSubscriber.onNext()for SSE streamsTest Coverage
Test plan
IllegalArgumentExceptionIllegalArgumentException🤖 Generated with Claude Code