Add support for 1.21.4, fix Serialization error, fix deprecations#141
Add support for 1.21.4, fix Serialization error, fix deprecations#141alexsvorada wants to merge 6 commits into
Conversation
|
Thank you very much for the PR. I will take the suggestions into account when I update and improve the plugin. However, I have to differentiate the changes somewhat and will implement some changes a bit differently. |
| .ignoreAirBlocks(true) | ||
| .build(); | ||
| Operations.completeBlindly(pasteBuilder); | ||
|
|
There was a problem hiding this comment.
According to my information, it should work just as well. Did you have problems with it?
| break; | ||
| case ERROR: | ||
| newMotd = Config.motdError(); | ||
| break; |
There was a problem hiding this comment.
Good idea. I wanted to expand the game status system in another update anyway.
| public static void setEnchantment(ItemStack itemStack) { | ||
| ItemMeta itemMeta = itemStack.getItemMeta(); | ||
| if (itemMeta != null) itemMeta.addEnchant(Enchantment.LUCK, 10, true); | ||
| if (itemMeta != null) itemMeta.addEnchant(Enchantment.LUCK_OF_THE_SEA, 10, true); |
There was a problem hiding this comment.
As the sword is used as a combat weapon, FORTUNE makes more sense here. People never actually fish in MissilesWars. ;)
(I am building my own update PR. You don't need to change it.)
| <repository> | ||
| <id>redstoneworld-repo</id> | ||
| <url>https://dl.cloudsmith.io/public/redstoneworld/RedUtilities/maven/</url> | ||
| </repository> |
There was a problem hiding this comment.
Since I installed the project locally, I had completely forgotten about it. Thank you.
2 participants
This PR should also fix #140 , solved by shadowing the jackson lib inside the jar to avoid dependency problems.
Server was able to start up without any errors, owner will test changes later today and I will report back.