Repository navigation
fix(raw): remove the RAW Decode panel; one fixed decode that never sh… - #2
Merged
Merged
Conversation
…ows a dark base Reported: a PEN-F ORF opened dark and grey. Decoding the file with both LibRaw engines and the app's exact flags gives a correct image, so the bad state came from the decode-settings machinery on the user's build. - RAW Decode panel, remembered decode defaults and the Settings RAW section removed. Every RAW opens with DCB + blended highlights + camera match; options older builds persisted per photo are ignored, so single and batch exports always match the editor. - Highlight recovery (post-decode) moved under Basic Adjustments for RAW photos, on the shared SliderRow. - A failed camera match no longer leaves the -W (un-brightened) base on screen: the native rung re-decodes with auto-brighten, the result is flagged cameraMatched:false and never written to the disk cache. Verified on the ORF: matched 0.319 mean, forced failure 0.401 instead of the dark base. - cameraMatchWorker.cjs is asarUnpacked and loaded from app.asar.unpacked in packaged builds; base cache key bumped (cm2) so bases cached by earlier builds miss once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CKGuP5pugDLEdjbRdfvFUV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ows a dark base
Reported: a PEN-F ORF opened dark and grey. Decoding the file with both LibRaw engines and the app's exact flags gives a correct image, so the bad state came from the decode-settings machinery on the user's build.
What does this PR do?
Related issue
Checklist
pnpm run typecheckpassespnpm run lintpasses (0 problems)pnpm run testpassesScreenshots (if UI-related)