Nolog4cxx - #2
Open
maihde wants to merge 6 commits into
Open
Conversation
added 6 commits
February 9, 2014 16:53
* Add --disable-logging to control the LOGGING define * Remove the redundant check for OSSIE_HAVELOG4CXX since that flag will be pulled from the OSSIE_CFLAGS (populated by ossie.pc) and must match the configuration that core framework was compiled with. * Properly use #if LOGGING instead of #ifdef LOGGING
When the core is built with --disable-log4cxx the LOGGER_PTR is a string.
This makes it consistent with the core framework and ensures that accidental copy pastes don't cause misleading trace logs to appear.
The deprecation warnings are for users of the library, but are not warnings in the context of building the library itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.