Skip to content

fix(ui): update Add widgets button to reflect drawer state #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karelhala merged 1 commit into from
Aug 20, 2026
+14 −9
Merged

fix(ui): update Add widgets button to reflect drawer state #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/Components/GenericHeader/GenericHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { ActionList, ActionListItem, Button, Flex, FlexItem, TextInput } from '@
import PageHeader from '@patternfly/react-component-groups/dist/dynamic/PageHeader';
import React, { useState } from 'react';
import { CheckIcon, PencilAltIcon, PlusCircleIcon, TimesIcon } from '@patternfly/react-icons';
import { useSetAtom } from 'jotai';
import { useAtom } from 'jotai';
import { drawerExpandedAtom } from '../../state/drawerExpandedAtom';
import { DashboardTemplate } from '../../api/dashboard-templates';
import GenericHeaderDropdown from './GenericHeaderDropdown';
Expand All @@ -16,7 +16,7 @@ interface GenericHeaderProps {
}

const GenericHeader = ({ dashboard, onRenameDashboard }: GenericHeaderProps) => {
const toggleOpen = useSetAtom(drawerExpandedAtom);
const [isDrawerExpanded, toggleOpen] = useAtom(drawerExpandedAtom);
const addNotification = useAddNotification();
const [isEditing, setIsEditing] = useState(false);
const [editedName, setEditedName] = useState('');
Expand Down Expand Up @@ -90,8 +90,13 @@ const GenericHeader = ({ dashboard, onRenameDashboard }: GenericHeaderProps) =>
actionMenu={
<ActionList>
<ActionListItem>
<Button onClick={() => toggleOpen((prev) => !prev)} variant="secondary" icon={<PlusCircleIcon />} ouiaId="add-widget-button">
Add widgets
<Button
onClick={() => toggleOpen((prev) => !prev)}
variant="secondary"
icon={isDrawerExpanded ? <TimesIcon /> : <PlusCircleIcon />}
ouiaId="add-widget-button"
>
{isDrawerExpanded ? 'Close widget panel' : 'Add widgets'}
</Button>
</ActionListItem>
{dashboard && (
Expand Down
10 changes: 5 additions & 5 deletions src/Components/Header/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@
MenuList,
MenuToggle,
PageSection,
TextInput,

Check warning on line 19 in src/Components/Header/Header.tsx

View workflow job for this annotation

GitHub Actions / lint 

'TextInput' is defined but never used
Toolbar,
ToolbarContent,
ToolbarGroup,
ToolbarItem,
} from '@patternfly/react-core';
import React, { useRef, useState } from 'react';
import { CodeIcon, CopyIcon, EditAltIcon, EllipsisVIcon, PlusCircleIcon, PlusIcon, ThIcon } from '@patternfly/react-icons';
import { useAtom, useSetAtom } from 'jotai';
import { CodeIcon, CopyIcon, EditAltIcon, EllipsisVIcon, PlusCircleIcon, PlusIcon, ThIcon, TimesIcon } from '@patternfly/react-icons';
import { useAtom } from 'jotai';
import { drawerExpandedAtom } from '../../state/drawerExpandedAtom';
import { templateIdAtom } from '../../state/templateAtom';
import { useApi } from '../../hooks/useApi';
Expand Down Expand Up @@ -207,7 +207,7 @@

const Controls = () => {
const [isOpen, setIsOpen] = useState(false);
const toggleOpen = useSetAtom(drawerExpandedAtom);
const [isDrawerExpanded, toggleOpen] = useAtom(drawerExpandedAtom);
const [templateId, setTemplateId] = useAtom(templateIdAtom);
const api = useApi();

Expand Down Expand Up @@ -250,10 +250,10 @@
toggleOpen((prev) => !prev);
}}
variant="primary"
icon={<PlusCircleIcon />}
icon={isDrawerExpanded ? <TimesIcon /> : <PlusCircleIcon />}
ouiaId="add-widget-button"
>
Add widgets
{isDrawerExpanded ? 'Close widget panel' : 'Add widgets'}
</Button>
</ToolbarItem>
</ToolbarGroup>
Expand Down
Loading