Skip to content

fix: hide disabled button under feature flag #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karelhala merged 1 commit into from
Aug 19, 2026
Merged

fix: hide disabled button under feature flag #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 22 additions & 12 deletions src/Components/DashboardHub/DashboardTable/DashboardTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,14 @@
return <Button variant="plain" aria-label="Duplicate" icon={<CopyIcon />} onClick={onClick} />;
};

export const DashboardTable: React.FunctionComponent<DashboardTableProps> = ({ dashboards, onRefetchDashboards }) => {

Check warning on line 34 in src/Components/DashboardHub/DashboardTable/DashboardTable.tsx

View workflow job for this annotation

GitHub Actions / lint 

'onRefetchDashboards' is defined but never used
const { exportDashboard, isLoading, error } = useExportDashboard();

Check warning on line 35 in src/Components/DashboardHub/DashboardTable/DashboardTable.tsx

View workflow job for this annotation

GitHub Actions / lint 

'error' is assigned a value but never used

Check warning on line 35 in src/Components/DashboardHub/DashboardTable/DashboardTable.tsx

View workflow job for this annotation

GitHub Actions / lint 

'isLoading' is assigned a value but never used
const { deleteDashboard, isLoading: isDeleting } = useDeleteDashboard();
const [dashboardToDelete, setDashboardToDelete] = useState<Dashboard | null>(null);
const [duplicateDashboardId, setDuplicateDashboardId] = useState<number | null>(null);
const isEnabledDelete = useFlag('platform.widget-layout.delete-dashboard');
const isEnabledShare = useFlag('platform.widget-layout.share');
const isEnabledEdit = useFlag('platform.widget-layout.edit_from_hub');
const addNotification = useAddNotification();
const setDefaultDashboard = useSetAtom(setDefaultDashboardAtom);

Expand Down Expand Up @@ -113,12 +115,16 @@

// Row actions for each dashboard
const getRowActions = (dashboard: Dashboard) => [
{
icon: <EditAltIcon />,
title: 'Edit dashboard',
isDisabled: true,
onClick: () => console.log(`Edit dashboard ${dashboard.id}`),
},
...(isEnabledEdit
? [
{
icon: <EditAltIcon />,
title: 'Edit dashboard',
isDisabled: true,
onClick: () => console.log(`Edit dashboard ${dashboard.id}`),
},
]
: []),
{
icon: <HomeIcon />,
title: 'Set as homepage',
Expand All @@ -131,12 +137,16 @@
title: 'Copy configuration string',
onClick: () => handleCopyConfiguration(dashboard),
},
{
icon: <UsersIcon />,
title: 'Share dashboard',
isDisabled: true,
onClick: () => console.log(`Share dashboard ${dashboard.id}`),
},
...(isEnabledShare
? [
{
icon: <UsersIcon />,
title: 'Share dashboard',
isDisabled: true,
onClick: () => console.log(`Share dashboard ${dashboard.id}`),
},
]
: []),
...(isEnabledDelete
? [
{
Expand Down
Loading