RHCLOUD-48760: Add SEC-MON-REQ-1 security logging - #573
Open
platex-rehor-bot wants to merge 1 commit into
Open
Conversation
RHCLOUD-48760 Add structured security event logging per SEC-MON-REQ-1 compliance: - EOI-5: STARTUP/SHUTDOWN lifecycle events for pt-api and pt-consumer - EOI-7: Authentication failure logging in checkForRole - EOI-8: Authorization failure logging for missing roles - Data access logging for archive link retrieval New securitylog package with helpers for auth, authz, lifecycle, and data access events. All events include required fields: action, resource_type, resource_id, outcome, and principal. Graceful shutdown added to pt-api for proper SHUTDOWN event capture. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Implements SEC-MON-REQ-1 security logging compliance for the Payload Tracker service (RHCLOUD-48760).
Why?
SEC-MON-REQ-1 requires structured security logging for Events of Interest (EOI) to meet compliance requirements.
How?
New
internal/securitylogpackage with structured helpers using logrus. All security events include the 5 required fields:action,resource_type,resource_id,outcome, andprincipal(org_id, user_id, type). Events are marked withsecurity_event: truefor log aggregation.Covered EOI categories:
pt-apiandpt-consumerbinariescheckForRoleExcluded (with justification):
Also adds graceful shutdown signal handling to
pt-apiso SHUTDOWN events are reliably captured.Testing
make build-allsucceedsAnything Else?
Principal extraction supports User, Associate, and ServiceAccount identity types from the x-rh-identity header. The package follows the same pattern used in other SEC-MON-REQ-1 implementations across the platform (insights-ingress-go, export-service-go, chrome-service-backend).
Secure Coding Practices Checklist Link
Secure Coding Checklist