Skip to content

fix(Kessel): check ancestry workspaces for permissions - #1779

Open
LightOfHeaven1994 wants to merge 1 commit into
RedHatInsights:masterfrom
LightOfHeaven1994:check-ancestry-workspaces
Open

fix(Kessel): check ancestry workspaces for permissions#1779
LightOfHeaven1994 wants to merge 1 commit into
RedHatInsights:masterfrom
LightOfHeaven1994:check-ancestry-workspaces

Conversation

@LightOfHeaven1994

Copy link
Copy Markdown
Contributor

Bugfix for host centric permissions check. We need with_ancestry=true param to be able to check default workspace for permissions as Default access RBAC group doesn't have workspaces read permissions by default.

How to test:

  1. Have admin and non org admin accounts
  2. You don't really need to do anything specific with permissions, just be sure that RBAC Default access is reset to default permissions.
  3. Navigate as non org admin account to Content Advisories page and see that workspaces API call is not failing with 403. Without that fix - workspaces API call fails with 403.

Before the change

Screenshot 2026-08-31 at 9 58 21

After the change

Screenshot 2026-08-31 at 9 58 30

Dependent work link

Checklist:

  • The commit message has the Jira ticket linked
  • PR has a short description
  • Screenshots before and after the change are added
  • Tests for the changes have been added
  • README.md is updated if necessary
  • Needs additional dependent work

@LightOfHeaven1994
LightOfHeaven1994 requested a review from a team as a code owner August 31, 2026 07:59
@LightOfHeaven1994 LightOfHeaven1994 self-assigned this Aug 31, 2026
@LightOfHeaven1994
LightOfHeaven1994 force-pushed the check-ancestry-workspaces branch from 1f1a826 to fbdce44 Compare August 31, 2026 08:00
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.36%. Comparing base (60a1fbf) to head (fbdce44).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1779   +/-   ##
=======================================
  Coverage   77.36%   77.36%           
=======================================
  Files         102      102           
  Lines        3283     3283           
  Branches      752      752           
=======================================
  Hits         2540     2540           
  Misses        664      664           
  Partials       79       79           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants