Skip to content

HMS-11117: delete whole filter type with multiple selected values - #1765

Open
Dugowitch wants to merge 4 commits into
RedHatInsights:masterfrom
Dugowitch:group-filter
Open

HMS-11117: delete whole filter type with multiple selected values#1765
Dugowitch wants to merge 4 commits into
RedHatInsights:masterfrom
Dugowitch:group-filter

Conversation

@Dugowitch

@Dugowitch Dugowitch commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Description

Associated Jira ticket: HMS-11117

Use and propagate deleteFilterGroup callback.

How to test the PR

Please include steps to test your PR.

Before the change

image

After the change

image

Dependent work link

Checklist:

  • The commit message has the Jira ticket linked
  • PR has a short description
  • Screenshots before and after the change are added
  • Tests for the changes have been added
  • README.md is updated if necessary
  • Needs additional dependent work

@Dugowitch Dugowitch changed the title Group filter HMS-11117: delete whole filter type with multiple selected values Aug 21, 2026
@Dugowitch
Dugowitch force-pushed the group-filter branch 2 times, most recently from 77e1a68 to 7c5350a Compare August 21, 2026 10:02
@codecov-commenter

codecov-commenter commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.52941% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.36%. Comparing base (a566a6c) to head (4699bbe).

Files with missing lines Patch % Lines
src/Utilities/hooks/Hooks.js 68.96% 6 Missing and 3 partials ⚠️
...c/SmartComponents/PackageSystems/PackageSystems.js 42.85% 4 Missing ⚠️
src/Utilities/Helpers.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1765      +/-   ##
==========================================
- Coverage   77.41%   77.36%   -0.06%     
==========================================
  Files         102      102              
  Lines        3286     3283       -3     
  Branches      755      752       -3     
==========================================
- Hits         2544     2540       -4     
- Misses        663      664       +1     
  Partials       79       79              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Dugowitch
Dugowitch marked this pull request as ready for review August 21, 2026 10:41
@Dugowitch
Dugowitch requested a review from a team as a code owner August 21, 2026 10:41
 
HMS-11117

Delete whole filter type with multiple selected values.
until now: [name (foo x) (bar x)]
fixed:     [name (foo x) (bar x) x]
 
HMS-11117

Delete whole filter type with multiple selected values.
until now: [name (foo x) (bar x)]
fixed:     [name (foo x) (bar x) x]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants