Skip to content

refactor: remove systems default filter - #1763

Open
Dugowitch wants to merge 1 commit into
RedHatInsights:masterfrom
Dugowitch:rm-default-filter
Open

refactor: remove systems default filter#1763
Dugowitch wants to merge 1 commit into
RedHatInsights:masterfrom
Dugowitch:rm-default-filter

Conversation

@Dugowitch

@Dugowitch Dugowitch commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Description

Associated Jira ticket: HMS-11196

There was a backend filter that the frontend filter counteracted. The backend filter was removed, the FE filter can now be removed as well. The BE now returns both fresh and stale systems by default.

Side effect of not having default filters: 'Reset filters' becomes 'Clear filters'.

How to test the PR

Please include steps to test your PR.

Before the change

After the change

Checklist:

  • The commit message has the Jira ticket linked
  • PR has a short description
  • Screenshots before and after the change are added
  • Tests for the changes have been added
  • README.md is updated if necessary
  • Needs additional dependent work

@codecov-commenter

codecov-commenter commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.38%. Comparing base (dfb1045) to head (8b7b32a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1763      +/-   ##
==========================================
- Coverage   77.41%   77.38%   -0.04%     
==========================================
  Files         102      102              
  Lines        3286     3286              
  Branches      756      752       -4     
==========================================
- Hits         2544     2543       -1     
- Misses        663      664       +1     
  Partials       79       79              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Dugowitch
Dugowitch marked this pull request as ready for review August 21, 2026 08:19
@Dugowitch
Dugowitch requested a review from a team as a code owner August 21, 2026 08:19
@Dugowitch
Dugowitch force-pushed the rm-default-filter branch 4 times, most recently from f5971d7 to a536e14 Compare August 24, 2026 12:14
HMS-11196

There was a backend filter that the frontend filter counteracted. The
backend filter was removed, the FE filter can now be removed as well.
The BE now returns both fresh and stale systems by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants