Overhaul styles for learning-resources settings page - #358
Merged
Conversation
Summary by CodeRabbit
WalkthroughThe catalog view adds localized header content, removes bookmark pagination, moves the header and filter into the initial section, removes section dividers, and updates catalog section, filter, header, and quickstart card styling. ChangesCatalog layout
Estimated code review effort: 2 (Simple) | ~15 minutes Sequence Diagram(s)sequenceDiagram
participant Viewer
participant CatalogHeader
participant Messages
participant CatalogFilter
Viewer->>CatalogHeader: render localized catalog header
CatalogHeader->>Messages: load title and description messages
Messages-->>CatalogHeader: return localized content
Viewer->>CatalogFilter: render catalog filter
CatalogFilter-->>Viewer: return expanded search layout and count
Viewer-->>Viewer: render complete bookmark collection
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/CatalogHeader.tsx`:
- Around line 26-29: Update the img element in CatalogHeader to use an empty alt
attribute, marking the header icon as decorative because the adjacent h1 already
identifies the page.
In `@src/Messages.ts`:
- Around line 468-475: Update src/Messages.ts lines 468-475 by including the
rich-text <a>All Learning catalog</a>. segment in catalogHeaderDescription, then
remove catalogHeaderAllLearningCatalogLink. In src/components/CatalogHeader.tsx
lines 37-51, pass the a rich-text formatter using /learning-resources,
target="_blank", and rel="noopener noreferrer" to the description message, and
remove the separate JSX link.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: 81e6f4ed-bf2b-4d8a-abc5-fa367fc5a365
📒 Files selected for processing (8)
src/Messages.tssrc/Viewer.tsxsrc/components/CatalogFilter.scsssrc/components/CatalogFilter.tsxsrc/components/CatalogHeader.scsssrc/components/CatalogHeader.tsxsrc/components/CatalogSection.scsssrc/components/GlobalLearningResourcesPage/GlobalLearningResourcesQuickstartItem.tsx
Collaborator
Author
|
/retest |
aferd
approved these changes
Aug 12, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For RHCLOUD-49626.
Visual Design & Layout
Navigation & Interaction
Content & Accessibility
Before:

After:
