fix(cachebust): prevent shell injection in purge paths - #687
Draft
petrsimon wants to merge 1 commit into
Draft
Conversation
petrsimon
force-pushed
the
fix/cachebust-injection-hardening
branch
from
August 24, 2026 12:06
b67d781 to
380c6b2
Compare
Pass akamaiCacheBustPaths as container Args via "$@" instead of interpolating into a shell string, and validate paths at CRD and runtime.
petrsimon
force-pushed
the
fix/cachebust-injection-hardening
branch
from
August 24, 2026 12:34
380c6b2 to
d011197
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
akamaiCacheBustPathswere previously interpolated directly into a shell command string, allowing a malicious path value to execute arbitrary shell code in the cache-bust Job container.Container.Argsentries via bash"$@", so no shell interpolation occurs.IsValidCacheBustPathvalidator (allowlist regex) filters any path that contains shell metacharacters at reconcile time, with a log warning per invalid entry.+kubebuilder:validationpattern annotation so the API server can reject obviously malformed values at admission.controllers/reconcile_cachebust_test.go(276 lines) covers normal paths, full URLs, deduplication, rejection of shell metacharacters, and edge cases.Test plan
make test— unit tests pass including newTestCreateCachePurgePathListcasesmake lint— no new lint errorsmake generate && make manifests— CRD YAML updated for pattern annotationcachebustandcachebust-multiple-urlsassert files updated to match new container command/args shape$(...)— operator logs skip message, path absent from Job args