Skip to content

Add ci for pytest on centos-10 and centos-9#26

Merged
jakub-vavra-cz merged 1 commit into
RedHat-SP-Security:masterfrom
jakub-vavra-cz:add_centos
Apr 16, 2026
Merged

Add ci for pytest on centos-10 and centos-9#26
jakub-vavra-cz merged 1 commit into
RedHat-SP-Security:masterfrom
jakub-vavra-cz:add_centos

Conversation

@jakub-vavra-cz
Copy link
Copy Markdown
Collaborator

@jakub-vavra-cz jakub-vavra-cz commented Apr 7, 2026

Add additional ci and update github action versions.

Summary by Sourcery

Extend CI coverage to additional CentOS images and update GitHub Actions versions in the main test workflow.

CI:

  • Run the pytest workflow against new centos-10 and centos-9 container tags.
  • Bump actions/checkout to v6 in repository checkout steps within the CI workflow.
  • Upgrade actions/upload-artifact to v7 for artifact handling in CI runs.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 7, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the CI GitHub Actions workflow to run pytest on additional CentOS images and to use newer major versions of core GitHub Actions.

File-Level Changes

Change Details Files
Extend the CI matrix and update GitHub Actions to newer major versions.
  • Add centos-10 and centos-9 to the Docker image test matrix alongside fedora-latest.
  • Update actions/checkout from v5 to v6 for both the main repository and the sudo-tests repository checkout steps.
  • Update actions/upload-artifact from v4 to v7 for artifact upload in the CI job.
.github/workflows/ci.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • With the new centos-10 and centos-9 tags in the matrix, double-check that downstream scripts and job steps that consume matrix.tag (e.g. image names, paths, or artifact processing) can handle these additional values and still resolve to valid images.
  • Since the GitHub Actions versions were bumped (checkout to v6 and upload-artifact to v7), confirm that any behavior that depended on previous-version defaults (e.g., fetch depth, retention, or artifact compression) is explicitly configured where needed to avoid subtle CI behavior changes.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- With the new `centos-10` and `centos-9` tags in the matrix, double-check that downstream scripts and job steps that consume `matrix.tag` (e.g. image names, paths, or artifact processing) can handle these additional values and still resolve to valid images.
- Since the GitHub Actions versions were bumped (`checkout` to v6 and `upload-artifact` to v7), confirm that any behavior that depended on previous-version defaults (e.g., fetch depth, retention, or artifact compression) is explicitly configured where needed to avoid subtle CI behavior changes.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jakub-vavra-cz jakub-vavra-cz force-pushed the add_centos branch 4 times, most recently from f9d6ede to 2150d8a Compare April 7, 2026 13:01
Add additional ci and update github action versions.
Comment thread .github/workflows/ci.yml
Copy link
Copy Markdown

@aplopez aplopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jakub-vavra-cz jakub-vavra-cz merged commit 2f1384b into RedHat-SP-Security:master Apr 16, 2026
4 checks passed
@jakub-vavra-cz jakub-vavra-cz deleted the add_centos branch April 16, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants