Add ci for pytest on centos-10 and centos-9#26
Merged
jakub-vavra-cz merged 1 commit intoApr 16, 2026
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the CI GitHub Actions workflow to run pytest on additional CentOS images and to use newer major versions of core GitHub Actions. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- With the new
centos-10andcentos-9tags in the matrix, double-check that downstream scripts and job steps that consumematrix.tag(e.g. image names, paths, or artifact processing) can handle these additional values and still resolve to valid images. - Since the GitHub Actions versions were bumped (
checkoutto v6 andupload-artifactto v7), confirm that any behavior that depended on previous-version defaults (e.g., fetch depth, retention, or artifact compression) is explicitly configured where needed to avoid subtle CI behavior changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- With the new `centos-10` and `centos-9` tags in the matrix, double-check that downstream scripts and job steps that consume `matrix.tag` (e.g. image names, paths, or artifact processing) can handle these additional values and still resolve to valid images.
- Since the GitHub Actions versions were bumped (`checkout` to v6 and `upload-artifact` to v7), confirm that any behavior that depended on previous-version defaults (e.g., fetch depth, retention, or artifact compression) is explicitly configured where needed to avoid subtle CI behavior changes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
f9d6ede to
2150d8a
Compare
2150d8a to
ddc5cb3
Compare
Add additional ci and update github action versions.
ddc5cb3 to
6bb38fe
Compare
aplopez
reviewed
Apr 16, 2026
shridhargadekar
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add additional ci and update github action versions.
Summary by Sourcery
Extend CI coverage to additional CentOS images and update GitHub Actions versions in the main test workflow.
CI: