Add regression/db-connection-leak-valgrind by sergio-correia · Pull Request #981 · RedHat-SP-Security/keylime-tests

sergio-correia · 2025-12-17T01:34:52Z

This test uses valgrind and is based on the existing test
regression/db-connection-leak-reproducer.

sourcery-ai · 2025-12-17T01:34:58Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This pull request currently contains no functional or content changes; it appears to be a placeholder or test PR with an empty diff for plans/main.fmf.

File-Level Changes

Change	Details	Files
No effective changes were made; the diff is empty and the file content is unchanged.	File is referenced in the diff header but has no added, removed, or modified lines. There is currently nothing to validate functionally or logically in the codebase for this PR.	`plans/main.fmf`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

@@ -0,0 +1,576 @@
+#!/bin/bash
+# vim: dict+=/usr/share/beakerlib/dictionary.vim cpt=.,w,b,u,t,i,k
+. /usr/share/beakerlib/beakerlib.sh || exit 1


+    rlRun "chown keylime:keylime '$log_dir'"
+
+    # Find keylime_verifier path (works for both RPM and upstream installs)
+    local verifier_path=$(command -v keylime_verifier)


+        return 1
+    fi
+
+    local log_files=$(find "$log_dir" -name "verifier-*.log" -type f)


+
+    # Analyze each log file
+    for log_file in $log_files; do
+        local pid=$(basename "$log_file" | sed 's/verifier-\(.*\)\.log/\1/')


+        rlLogInfo "Analyzing worker process $pid (worker #$num_workers)"
+
+        # Count open file descriptors at exit for this specific PID
+        local open_fds=$(grep "^==${pid}== Open file descriptor" "$log_file" | wc -l)


+
+            # Check specifically for SQLite database FD leaks
+            local sqlite_fds=$(grep "^==${pid}== Open file descriptor.*cv_data.sqlite" "$log_file" | wc -l)
+            if [ $sqlite_fds -gt 0 ]; then


+                rlLogWarning "  Worker $pid: $sqlite_fds leaked SQLite database connections!"
+                leaked_sqlite_fds=$((leaked_sqlite_fds + sqlite_fds))
+                workers_with_sqlite_leaks=$((workers_with_sqlite_leaks + 1))
+                worker_sqlite_leaks[$pid]=$sqlite_fds


+                leaked_sqlite_fds=$((leaked_sqlite_fds + sqlite_fds))
+                workers_with_sqlite_leaks=$((workers_with_sqlite_leaks + 1))
+                worker_sqlite_leaks[$pid]=$sqlite_fds
+                has_leaks=1


+        rlLogInfo "=== VALGRIND TEST COMPLETE ==="
+        rlLogInfo "All valgrind logs saved to: $VALGRIND_BASE_DIR"
+        rlLogInfo "Phases analyzed:"
+        find "$VALGRIND_BASE_DIR" -mindepth 1 -maxdepth 1 -type d | while read phase_dir; do


+        rlLogInfo "All valgrind logs saved to: $VALGRIND_BASE_DIR"
+        rlLogInfo "Phases analyzed:"
+        find "$VALGRIND_BASE_DIR" -mindepth 1 -maxdepth 1 -type d | while read phase_dir; do
+            rlLogInfo "  - $(basename $phase_dir)"


kkaarreell

I have just a few nitpicks.
However, it seems that the test reports various connection leaks even for the current upstream code and not consistently.

kkaarreell · 2026-03-25T06:58:42Z

+  - valgrind
+recommend:
+  - keylime
+  - python3-tomli


this is not needed as we are not running a revocation script

"This" here meaning the python3-tomli line?

I removed the python3-tomli line there. Please let me know if it still needs adjusts.

This test uses valgrind and is based on the existing test regression/db-connection-leak-reproducer. It reproduces scenarios that would have caused connection leaks before the fix from PR keylime/keylime#1782. Signed-off-by: Sergio Correia <scorreia@redhat.com>

Also try to reduce the tests executed to the ones we care about. Signed-off-by: Sergio Correia <scorreia@redhat.com>

sourcery-ai Bot reviewed Dec 17, 2025

View reviewed changes

sergio-correia marked this pull request as draft December 17, 2025 01:36

sergio-correia force-pushed the db-leaks branch from b8f9b08 to 51c968b Compare January 22, 2026 19:32

github-advanced-security AI found potential problems Jan 22, 2026

View reviewed changes

sergio-correia force-pushed the db-leaks branch from 51c968b to e29f503 Compare January 22, 2026 19:33

sergio-correia changed the title ~~DO NOT MERGE - test redirect~~ Add regression/db-connection-leak-valgrind Jan 22, 2026

sergio-correia force-pushed the db-leaks branch from e29f503 to e1ac256 Compare March 24, 2026 09:38

kkaarreell requested changes Mar 25, 2026

View reviewed changes

sergio-correia force-pushed the db-leaks branch from e1ac256 to 8f148b4 Compare March 25, 2026 10:23

sergio-correia force-pushed the db-leaks branch from 8f148b4 to 8c6959a Compare March 30, 2026 11:56

DO NOT MERGE - update repo/branch for testing

e2a09b7

Also try to reduce the tests executed to the ones we care about. Signed-off-by: Sergio Correia <scorreia@redhat.com>

sergio-correia force-pushed the db-leaks branch from 8c6959a to e2a09b7 Compare March 30, 2026 14:27

Conversation

sergio-correia commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sourcery-ai Bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

kkaarreell left a comment

Choose a reason for hiding this comment

Uh oh!

kkaarreell Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

sergio-correia Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

sergio-correia Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sergio-correia commented Dec 17, 2025 •

edited

Loading

sourcery-ai Bot commented Dec 17, 2025 •

edited

Loading