[OLD] Draft: Do not run upstream tests as root#213
Open
ansasaki wants to merge 2 commits into
Open
Conversation
The upstream tests do not need to run as root anymore. Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
Collaborator
|
HI @ansasaki , are those missing dependencies something that has been newly added to keylime? Or maybe a package set installed by default on a test system has changed. EDIT: It rather looks like a bug in a test case code |
Contributor
Author
There are no new dependencies, it is just that the upstream test suite were not installing the dependencies needed to build the rust agent, but now they are being installed.
Yes, this is not finished yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to make the tests compatible with keylime/keylime#1132 in which the upstream tests are not required to be executed as root anymore.