Add TESTS_REPOSITORY_BRANCHING.md#1071
Merged
Merged
Conversation
Reviewer's GuideDocuments branching strategy, dynamic tmt ref mapping, and CI configuration workflows for the keylime-tests repository, focusing on how to create and maintain RHEL and Fedora test branches and how to handle rebases safely. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In the YAML snippets, consider quoting string-valued conditions like
distro == 'rhel-10.1'/'fedora-42'to avoid ambiguity with dotted numeric-like values in some YAML parsers and to make copy-paste usage safer. - The guide is quite long; you might improve navigability by adding a short table of contents at the top with links to the three main scenarios and the checklists, so that people can quickly jump to the workflow they need.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the YAML snippets, consider quoting string-valued conditions like `distro == 'rhel-10.1'`/`'fedora-42'` to avoid ambiguity with dotted numeric-like values in some YAML parsers and to make copy-paste usage safer.
- The guide is quite long; you might improve navigability by adding a short table of contents at the top with links to the three main scenarios and the checklists, so that people can quickly jump to the workflow they need.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Documentation: