Skip to content

[claude-code] trivial ssa destruction implementation#55

Draft
RealA10N wants to merge 1 commit intomainfrom
43-implement-ssa-destruction
Draft

[claude-code] trivial ssa destruction implementation#55
RealA10N wants to merge 1 commit intomainfrom
43-implement-ssa-destruction

Conversation

@RealA10N
Copy link
Copy Markdown
Owner

@RealA10N RealA10N commented Mar 14, 2026

This is my first vibe coding experience. I just gave claude code a link to #43 and it went and implemented it. Burned 4.25$ (API) with Claude Opus 4.6.

Seems like a decent implementation to be, although it took the trivial approach, and not the approach I intended in #43. Needs some more polish before merging (for example, I don't like the generated label names currently, and the tests structure can be improved, and more tests should be added).

Plus, I did not touch to project for a year+, so I do not feel comfortable to merge this because I do not remember the project structure, best practices, etc. So for now I'm leaving it and hopefully I will make the appropriate changes & merge some day.

@RealA10N RealA10N linked an issue Mar 14, 2026 that may be closed by this pull request
@RealA10N RealA10N marked this pull request as draft March 14, 2026 16:44
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 14, 2026

Codecov Report

❌ Patch coverage is 81.57895% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.42%. Comparing base (47fd24d) to head (093cfd1).

Files with missing lines Patch % Lines
usm/ssa/ssa_destruction.go 75.00% 11 Missing and 1 partial ⚠️
gen/basic_block_info.go 0.00% 7 Missing ⚠️
usm/ssa/critical_edge_splitting.go 91.52% 4 Missing and 1 partial ⚠️
usm/ssa/parallel_copy.go 89.47% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   36.32%   43.42%   +7.09%     
==========================================
  Files         122      125       +3     
  Lines        4583     3853     -730     
==========================================
+ Hits         1665     1673       +8     
+ Misses       2838     2078     -760     
- Partials       80      102      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement SSA Destruction

1 participant