Repository navigation
Extend text ranges when merging CDATA fragments - #156
Open
mikamikasuki wants to merge 1 commit into
Open
mikamikasuki wants to merge 1 commit into
mikamikasuki wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adjacent text and CDATA fragments are merged,
Node::range()currently ends at the first fragment. Extend the end position as further document fragments are appended. Ignore offsets from entity expansions, which can refer to the DTD or external input.Regression coverage includes both text/CDATA orders, consecutive and empty CDATA, CRLF normalization, Unicode, character references, node boundaries, and preservation of external entity offsets.
Fixes #112.
Validation: all 300 unit/integration tests and 32 doctests pass with default features; all 291 tests and 32 doctests pass without positions. Builds without
stdpass with and without positions. The 26 API tests also pass under Rust 1.60 using compatible memchr 2.5.0. Tested on arm64 macOS.Prepared with AI assistance.