Parse element content iteratively - #155
Merged
Merged
Conversation
Contributor
Author
|
Added additional commit. Can rebase it at a final stage when approved. |
adamreichold
approved these changes
Sep 20, 2026
jaytaph
changed the title
Document::parse recursed once per level of element nesting without bounds and can result in a stack overflow (which will abort the application). This commit changes this into a single loop so very deep nestings can be done safely without overflow.
jaytaph
force-pushed
the
depth-limit
branch
from
September 21, 2026 18:15
16e6bda to
9b8918c
Compare
adamreichold
approved these changes
Sep 22, 2026
adamreichold
left a comment
adamreichold
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. (I am holding off merging for a bit to give others a chance to chime in.)
Owner
|
Looks good. Except I wonder how long |
Collaborator
Takes less than 200ms on my puny Ryzen 5 5600U... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document::parse recursed once per level of element nesting without bounds and can result in a stack overflow (which will abort the application).
This commit changes this into a single loop so very deep nestings can be done safely without overflow, and it adds a limit configuration option which can be used to cap the depth.
Fixes #154