Conversation
Author
|
Moved discussion re unix counterpart to #137 |
Author
|
@de-vri-es I see most recent merge belongs to you, could you perhaps take a look at this? |
gim913
commented
Jan 22, 2025
| handle: None, | ||
| ptr, | ||
| len, | ||
| len, // TODO: should this be mapped_len in case of huge page |
Author
There was a problem hiding this comment.
I'm guessing, the answer to this is probably "no", as thing returned to user should have length one requested.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I've added windows implementation of large/huge pages.
There are few (3) places, where I wasn't sure what to do, I've marked them with
TODO:sLinks to some info, that might be helpful:
P.S. I've tried to keep the changes minimal.