Window the gallery to a sliding page buffer - #3
Merged
Merged
Conversation
The gallery held every page ever scrolled through: useInfiniteQuery accumulated pages with no cap, and each append rebuilt ~7 full-set derived structures (groups, id->index map, justified layout) over the entire loaded library. Memory grew unbounded and per-append work grew O(n), so the tab slowed then crashed on large libraries. Switch to a bounded sliding window: - useShellData: offset-addressed pageParams + getPreviousPageParam + maxPages, so React Query evicts the far page as you scroll. Exposes windowStart, fetchPreviousPage, hasPreviousPage. - shellPaging: page size 2000 -> 300, WINDOW_PAGES=5 (~1500 items held max); seekWindowOffsets replaces the prefix-fill seek helpers. - GalleryGrid: re-anchor scrollTop by the exact row-height delta when the window slides (evict-above/prepend) so content never jumps; top-edge lookahead mirrors the bottom one. - seekToIndex rebuilds the window around the target instead of filling a contiguous prefix from index 0. - useTimelineScrollbar: window-relative index math (global = windowStart + local) so the scrubber stays honest to the whole library while only a window is loaded. No height estimation: every height used is exact from the justified layout. Typecheck, lint, and all tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gallery held every page ever scrolled through: useInfiniteQuery accumulated pages with no cap, and each append rebuilt ~7 full-set derived structures (groups, id->index map, justified layout) over the entire loaded library. Memory grew unbounded and per-append work grew O(n), so the tab slowed then crashed on large libraries.
Switch to a bounded sliding window:
No height estimation: every height used is exact from the justified layout. Typecheck, lint, and all tests pass.