Propagate proxy inner post-dispatch weight - #3063
Open
UnArbosSix wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
🛡️ AI Review — Skeptic (security review)VERDICT: VULNERABLE HIGH scrutiny: account is under 90 days old with no public repositories, mitigated by repository write permission and substantive merged contributions; fix/proxy-post-dispatch-weight-refund targets main. Findings
Other findings
ConclusionThe weight-refund implementation appears sound, but changing runtime dispatch behavior without incrementing # 🔍 AI Review — Auditor (domain review) has not yet run on this PR. |
Contributor
|
🔄 AI review updated — Skeptic: VULNERABLE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix proxy calls failing to refund unused inner-call weight.
Both
Proxy::proxyandProxy::proxy_announceddeclared the inner call's worst-case weight but returned a plainDispatchResult. Although the inner dispatch populatedpost_info.actual_weight,do_proxydiscarded it after recording the result.This caused transaction payment to charge the full declared weight for proxied calls, even when the inner call reported lower actual weight.
Changes
DispatchResultWithPostInfofromproxyandproxy_announced.extract_actual_weight.LastCallResultandProxyExecutedbehavior.Validation
pallet-subtensor-proxytests pass.no_stdcheck passes.2,664,017,457735,182,2571,386,563rao368,067rao1,018,496raoTransactionFeePaid.actual_fee.