Skip to content

Prevent stale release approvals from blocking newer runtimes - #3059

Open
UnArbosFive wants to merge 1 commit into
release-444from
fix/release-watcher-supersession
Open

Prevent stale release approvals from blocking newer runtimes#3059
UnArbosFive wants to merge 1 commit into
release-444from
fix/release-watcher-supersession

Conversation

@UnArbosFive

@UnArbosFive UnArbosFive commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Preserve the existing mainnet environment approval and everything it currently authorizes: branch mirroring, GitHub release promotion, Docker dispatch, package publication, and production docs deployment.
  • Replace the workflow-wide queue with a runtime-specific release slot so an unanswered approval for an older runtime cannot block a newer runtime.
  • Cancel superseded waiting publication runs, while never interrupting a job that has started executing.
  • Suppress duplicate release and wheel-build work when another watcher already owns the same runtime slot.
  • Revalidate the finalized runtime spec and exact code hash immediately after approval, before changing the mainnet mirror or GitHub release.

Why

Runtime v442 executed on chain, but its watcher remained at the separate publication approval. The workflow-wide concurrency lock then prevented the v443 watcher from reaching its own approval. This keeps the two-approval security model while removing that cross-runtime failure mode.

This PR targets the release-444 branch from #3058 and requires normal review before any behavior changes land.

Test plan

  • .github/scripts/test-cancel-superseded-release-watchers.sh
  • bash syntax checks for the new scripts
  • YAML parse checks for both modified workflows
  • git diff --check

@vercel

vercel Bot commented Aug 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
subtensor Ready Ready Preview Aug 6, 2026 5:03pm

Request Review

@UnArbosFive
UnArbosFive force-pushed the fix/release-watcher-supersession branch from bad013d to 07bc4e2 Compare August 6, 2026 17:00
@UnArbosFive UnArbosFive changed the title Make release watcher supersession-safe Prevent stale release approvals from blocking newer runtimes Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant