fix: permit transactional maintenance health - #58
Merged
Conversation
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #57 for a deployment-blocking transaction-health interaction found while exercising the merged upgrade and rollback paths.
Root cause
Activation intentionally runs health before committing installation state. At that point, maintenance oneshots can still report the previous revision's result; treating those historical results as candidate failures makes a healthy activation roll back. The rollback verifier had the same issue and could reject a correctly restored checkpoint.
Verification
python3 -m unittest discover -s scripts -p 'test_*.py'./scripts/test-install-worker-controller.shshellcheck scripts/*.sh examples/project/scripts/ci/*.sh templates/config-repository/scripts/*.sh