Skip to content

docs: close quickstart onboarding safety gaps - #51

Merged
Nickfost merged 3 commits into
mainfrom
docs/quickstart-review-followup
Jul 27, 2026
Merged

docs: close quickstart onboarding safety gaps#51
Nickfost merged 3 commits into
mainfrom
docs/quickstart-review-followup

Conversation

@Nickfost

Copy link
Copy Markdown
Member

Summary

Closes the remaining onboarding-safety gaps identified while reconciling merged quickstart PR #49:

  • requires an amd64 or arm64 Docker host before installation;
  • requires auditing and cancelling every queued job that could match the shared pool label before repository authorization, with an empty proof repository/group as the fail-closed fallback;
  • scopes Docker residue checks to the repository, run ID, and run attempt while preserving slash-anchored container names;
  • removes a duplicated phrase introduced during concurrent documentation reconciliation;
  • adds a small runnable quickstart contract check and wires it into repository validation.

The change is documentation and validation-test only. It does not modify hosts, controllers, runners, capacity, runner groups, VMs, deployment infrastructure, or production.

Validation

  • TDD RED: scripts/test_quickstart.py failed on the missing architecture prerequisite before the documentation fix;
  • git diff --check: passed;
  • shell syntax checks: passed;
  • Python compilation: passed;
  • planner, desired-state, health, quickstart, capacity-preflight, and installer tests: passed;
  • fast/full plan expansion: passed;
  • committed-secret scan: passed;
  • full Docker build validation is delegated to pull-request CI.

Advances #24. Follow-up to #49.

Signed-off-by: Nickfosts Hermes <me@nickfost.com>
@Nickfost

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 92e106b8c6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/QUICKSTART.md Outdated
Comment thread docs/QUICKSTART.md Outdated
Signed-off-by: Nickfosts Hermes <me@nickfost.com>
@Nickfost

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 17a1fb1725

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/QUICKSTART.md
Comment thread docs/QUICKSTART.md Outdated
Signed-off-by: Nickfosts Hermes <me@nickfost.com>
@Nickfost

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: f8b329dfd7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Nickfost
Nickfost merged commit b3f0f9d into main Jul 27, 2026
1 check passed
@Nickfost
Nickfost deleted the docs/quickstart-review-followup branch July 27, 2026 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant