docs: make disposable-controller failure boundary explicit - #48
Merged
Conversation
A disposable controller's recovery path is rebuilding from reviewed Git-authored desired state; machine backups, snapshots, and tar archives apply only to hosts declared recoverable under local policy. Installer transactional checkpoints are unchanged.
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The merged runbook required a VM backup/snapshot and console-recovery proof before placing credentials on any host. For an intentionally disposable controller that gate is wrong: recovery from catastrophic failure is rebuilding the host from reviewed Git-authored desired state. This blocked VM 130 (
rd-ci-fleet-01) reconciliation behind an unnecessary machine-backup requirement.What changed
docs/ADDING-A-HOST.md: hosts now declare a failure boundary — disposable (rebuild from Git-authored configuration, no machine backup/snapshot/tar required) or recoverable (documented build + backup procedure).docs/DESIRED-STATE.md: installer checkpoints vs machine backups are framed as different failure classes; disposable controllers need no machine backup.What did NOT change
Docs-only; no behavioral change.