Skip to content

fix(capacity): validate reviewed runner targets - #47

Merged
Nickfost merged 3 commits into
mainfrom
fix/generic-capacity-preflight
Jul 24, 2026
Merged

fix(capacity): validate reviewed runner targets#47
Nickfost merged 3 commits into
mainfrom
fix/generic-capacity-preflight

Conversation

@Nickfost

@Nickfost Nickfost commented Jul 24, 2026

Copy link
Copy Markdown
Member

Summary

  • allow the post-pilot preflight to validate any reviewed positive target
  • keep resource, idle-state, identity, and residue gates unchanged
  • document parameterized pre/post checks and proof limits

Validation

  • ./scripts/test-capacity-preflight.sh
  • bash -n scripts/capacity-preflight.sh scripts/test-capacity-preflight.sh
  • git diff --check
  • ./scripts/validate.sh passes through installer tests, then stops because Docker is unavailable on this host

This closes the repository gate mismatch with the private MAX=6 desired state. It does not apply configuration or mutate runners/VMs.

@Nickfost

Copy link
Copy Markdown
Member Author

@codex review

Please review exact head 5b98aeeda30226aba8f7685bff31015645d369a8, especially the generic target-capacity gate, arithmetic bounds, and parameterized runbook commands.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Unknown error
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Nickfost

Copy link
Copy Markdown
Member Author

@codex review

Retry review of exact head 5b98aeeda30226aba8f7685bff31015645d369a8; the previous connector attempt returned an unknown error.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Unknown error
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5b98aeeda3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/CAPACITY-PROMOTION.md
@Nickfost

Copy link
Copy Markdown
Member Author

@codex review

Please perform a fresh review of exact head d866bffb0c3e184b31c02a7175163c0d75c44999. The accepted rollback finding is fixed and covered by a focused regression assertion.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Unknown error
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d866bffb0c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/CAPACITY-PROMOTION.md
Comment thread docs/CAPACITY-PROMOTION.md Outdated
@Nickfost

Copy link
Copy Markdown
Member Author

@codex review

Please perform a fresh review of exact head 2b00989c5c308b6e6ab7abfad9d348f2d0871914. Both accepted findings from the prior review are fixed with focused regression assertions.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Unknown error
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 2b00989c5c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Nickfost
Nickfost merged commit 84859c5 into main Jul 24, 2026
1 check passed
@Nickfost
Nickfost deleted the fix/generic-capacity-preflight branch July 24, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants