fix(health): schedule after timer activation - #45
Merged
Conversation
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VM 130 read-only verification found
ci-fleet-health.timeractive but elapsed with no next trigger after the managed installer restarted it long after boot.OnBootSecwas already in the past, while the last health service activation predated the restart, so neither monotonic trigger scheduled a future run.Use the native activation-relative
OnActiveSec=2mininitial trigger and retainOnUnitActiveSec=5minfor recurrence. Add one installer-suite regression asserting the timer cannot regress to boot-relative startup.Validation:
./scripts/test-install-worker-controller.shpython3 -m unittest scripts/test_health.pygit diff --checkNo host state was changed.