Add fleet-wide host health monitoring - #42
Conversation
|
@codex review Please review the exact current head for secret exposure, unsafe cleanup or mutation, false healthy/false unhealthy states, threshold and lifecycle handling, heartbeat trust-boundary validation, installer rollback behavior, timer semantics, and deterministic regression coverage. |
|
@codex review Please review exact head 19ff666 after the non-root installer-fixture ownership fix. Recheck the complete diff and especially secret handling, stale-resource classification, timer age parsing, lifecycle states, warning/critical installer semantics, heartbeat configuration versus delivery failure, rollback/uninstall scope, and test coverage. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 19ff666a1f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review the complete PR at exact head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 80f37d1268
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review the complete PR at exact head |
|
@codex review Please review exact head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cad423225e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…itoring # Conflicts: # scripts/test-install-worker-controller.sh
|
@codex review Please review exact head |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Closes #34.
Adds one redacted local health command, persisted machine-readable results, scheduled warning semantics, provider-neutral HTTPS heartbeats, external missed-heartbeat evaluation, host-local threshold/backup hooks, installer rollback integration, and operator recovery guidance.
Safety: no repair or global prune behavior; monitoring credentials remain host-local; warning exit 1 does not fail systemd or installer activation; critical exit 2 does.
Validated locally (the current workstation has no Docker daemon, so image/Compose validation is delegated to GitHub Actions):