Add Git-authored controller desired state by Nickfost · Pull Request #33 · RandomDevelopment/ci-fleet

Nickfost · 2026-07-18T22:20:59Z

Closes #32.

Advances #21 by adding the engine-side installer and adoption workflow that consumes Git-authored private controller configuration.

What changed

vendors the schema-v3 controller, pool, location, and capacity contract
adds strict desired-state validation and host-safe environment rendering
adds one-command --check, --install, --adopt, --upgrade, --rollback, and --uninstall modes
pins both private configuration and public engine revisions to full commit SHAs
adds drain-aware upgrades, atomic release staging, complete checkpoints, verified failed-activation rollback, host-local locking, and periodic drift detection
preserves prior runtime, manager, and maintenance-unit/timer state across rollback
keeps capacity in private infrastructure configuration while application workflows submit all independent jobs
documents fresh installation, legacy adoption, maintenance, secrets, and rollback

Security and operating boundaries

no credentials, private endpoints, or host addresses are committed
private Git credentials remain host-side and may be read-only
the installer rejects embedded URL credentials and moving branch refs
controller changes drain managed runners before replacement
rollback does not restart a controller while a managed runner remains active
cleanup remains scoped and does not perform global Docker pruning
VM or machine backups remain an external infrastructure checkpoint
existing ignore rules for local configuration, credentials, keys, and runtime state remain enforced

Validation

Passed at current head:

shell syntax and diff checks
11 desired-state unit tests
31 private-configuration policy tests
deterministic installer tests covering fresh install, idempotency, worktree execution, drift, repair, failed activation rollback, runtime/manager restoration, upgrades, drained state, uninstall, and legacy adoption
existing planner and capacity-preflight tests
reference, multi-host, and freshly initialized template validation
a real Docker pause→stop and queued-SIGTERM proof on isolated disposable development-host containers
full isolated development-host validation of head 61b9728eda98c70db93f2254c2dc5a955a1774b7, including both image builds, runner tool smoke tests, cleanup dry-run, and dependency-free tracked-secret scan
all 41 valid Codex findings addressed; one signal-order suggestion rejected with direct Docker 29.6.2 evidence; every inline review thread resolved

The repository's GitHub Actions workflow additionally runs ShellCheck and Docker image builds.

Related work

private-template contract: Add controller desired state and infrastructure-owned capacity to the template ci-fleet-config-template#1
live private adoption remains a separate reviewed change in the private desired-state repository

Nickfost · 2026-07-18T23:19:30Z

@codex review

Nickfost · 2026-07-18T23:21:46Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a5d2ed418e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Nickfost · 2026-07-18T23:32:33Z

@codex review

Nickfost · 2026-07-18T23:39:10Z

@codex review

Nickfost · 2026-07-18T23:40:23Z

@codex review

Nickfost · 2026-07-18T23:43:20Z

@codex review

Nickfost · 2026-07-18T23:45:21Z

@codex review

Nickfost · 2026-07-18T23:47:58Z

@codex review

Nickfost · 2026-07-18T23:49:53Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea376240d4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Nickfost · 2026-07-19T00:02:15Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c71942afc7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Nickfost · 2026-07-21T18:09:47Z

@codex review

Please review exact head df5a79c after the latest fixes. Focus on live controller environment/provenance reconciliation, install-state trust repair, all-state managed-runner cleanup for non-active targets, complete committed-content scanning without whole-file exemptions, scoped non-destructive behavior, and final reviewed engine pins. Reproducible image inputs are deliberately tracked in follow-up issue #36.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: df5a79cc78

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Nickfost · 2026-07-22T05:25:33Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 548ba9132a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Nickfost · 2026-07-22T06:21:53Z

@codex review

Nickfost · 2026-07-22T06:35:22Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e4b491696

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Nickfost · 2026-07-22T07:34:03Z

@codex review

Nickfost · 2026-07-22T07:45:04Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 59a8a7a204

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Nickfost · 2026-07-22T08:32:26Z

@codex review

chatgpt-codex-connector · 2026-07-22T08:43:07Z

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 8365b3de38

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Nickfost added 3 commits July 18, 2026 17:20

Add Git-authored controller desired state

5e8d581

Fix installer drift check lint

c600165

fix(installer): restore complete checkpoints safely

3a09609

Nickfost marked this pull request as ready for review July 18, 2026 23:19

fix(installer): satisfy shellcheck timer capture

a5d2ed4

chatgpt-codex-connector Bot reviewed Jul 18, 2026

View reviewed changes

Comment thread scripts/install-worker-controller.sh Outdated

Comment thread templates/config-repository/scripts/validate.py

test(config): derive capacity overcommit fixtures

87c21c2

fix(config): align drain and managed minimum

a0b8c17

test: isolate validation image tags

593ce2b

fix(installer): name the managed controller container

dadd983

refactor(installer): use Python for metadata state

ab76d65

fix(installer): advance the maintenance manager

d157449

test: make committed-secret scan dependency-free

ea37624

chatgpt-codex-connector Bot reviewed Jul 18, 2026

View reviewed changes

Comment thread templates/config-repository/scripts/init.py Outdated

Comment thread scripts/install-worker-controller.sh

Comment thread scripts/install-worker-controller.sh Outdated

fix(installer): make reviewed upgrades applicable

a1f8823

Nickfost added 5 commits July 18, 2026 19:03

fix: drain before managed preflight

971f8ee

test: cover drain ordering and relative config paths

f657117

fix: pin examples to compatible engine release

1b92b8e

fix: pin examples to compatible engine release

641e4cd

fix: pin examples to compatible engine release

d76f2eb

chatgpt-codex-connector Bot reviewed Jul 21, 2026

View reviewed changes

Nickfost mentioned this pull request Jul 21, 2026

feat: Pin managed image base images and package inputs by digest for reproducible pinned-engine rebuilds #36

Open

Nickfost added 2 commits July 21, 2026 13:03

fix(installer): reconcile live runtime trust

a530c6a

docs: pin final runtime-trust engine

df5a79c

chatgpt-codex-connector Bot reviewed Jul 21, 2026

View reviewed changes

Nickfost added 2 commits July 22, 2026 00:19

fix: harden controller convergence integrity

8c51334

chore: advance reviewed engine pins

548ba91

chatgpt-codex-connector Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread scripts/install-worker-controller.sh

Comment thread scripts/install-worker-controller.sh Outdated

Comment thread scripts/install-worker-controller.sh

Comment thread scripts/install-worker-controller.sh Outdated

Comment thread docs/ADDING-A-HOST.md

Nickfost added 2 commits July 22, 2026 01:19

fix: close controller adoption review gaps

b1da110

chore: advance final engine pins

058f10d

docs: align template with accepted controller scope

4e4b491

chatgpt-codex-connector Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread scripts/install-worker-controller.sh Outdated

Comment thread templates/config-repository/fleet.json Outdated

Comment thread scripts/install-worker-controller.sh Outdated

Nickfost added 2 commits July 22, 2026 02:28

fix: verify releases and rollback candidates

47277cf

chore: advance reviewed release integrity pins

4291b9b

Nickfost added 2 commits July 22, 2026 02:39

fix: satisfy rollback shell lint

0b71755

chore: advance lint-clean engine pins

59a8a7a

chatgpt-codex-connector Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread scripts/install-worker-controller.sh Outdated

Comment thread docs/CAPACITY-PROMOTION.md Outdated

Comment thread scripts/install-worker-controller.sh Outdated

Comment thread scripts/install-worker-controller.sh Outdated

Nickfost added 2 commits July 22, 2026 03:27

fix: harden convergence drain lifecycle

254b98a

chore: advance drain-safe engine pins

8365b3d

Nickfost merged commit f5da1fc into main Jul 22, 2026
1 check passed

Nickfost deleted the agent/git-authored-controller-desired-state branch July 24, 2026 03:51

Nickfost mentioned this pull request Aug 26, 2026

feat: Add Docker default-address-pools policy, subnet-headroom health gate, and controller circuit breaker for managed fleet lifecycle #81

Open

Uh oh!

Conversation

Nickfost commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed

Security and operating boundaries

Validation

Related work

Uh oh!

Nickfost commented Jul 18, 2026

Uh oh!

Nickfost commented Jul 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Nickfost commented Jul 18, 2026

Uh oh!

Nickfost commented Jul 18, 2026

Uh oh!

Nickfost commented Jul 18, 2026

Uh oh!

Nickfost commented Jul 18, 2026

Uh oh!

Nickfost commented Jul 18, 2026

Uh oh!

Nickfost commented Jul 18, 2026

Uh oh!

Nickfost commented Jul 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nickfost commented Jul 19, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nickfost commented Jul 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nickfost commented Jul 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nickfost commented Jul 22, 2026

Uh oh!

Nickfost commented Jul 22, 2026

Uh oh!

Nickfost commented Jul 18, 2026 •

edited

Loading