Skip to content

feat(ops): add post-pilot capacity promotion checks - #31

Merged
Nickfost merged 6 commits into
mainfrom
hermes/post-pilot-capacity-promotion
Jul 17, 2026
Merged

feat(ops): add post-pilot capacity promotion checks#31
Nickfost merged 6 commits into
mainfrom
hermes/post-pilot-capacity-promotion

Conversation

@Nickfost

@Nickfost Nickfost commented Jul 17, 2026

Copy link
Copy Markdown
Member

Summary

  • preserve the strict initial pilot MIN=0, MAX=1 preflight unchanged;
  • add a separate, explicit post-pilot capacity validator;
  • add deterministic CPU, memory, disk, drain, configured/effective-state, OOM, unrelated-workload, and secret-output checks;
  • document exact backup, controller-only recreation, verification, retain, restore, and rollback steps;
  • link host enrollment to the reviewed procedure.

Safety boundary

  • The PR does not apply target MAX=2 to any host.
  • Repository merge modifies no controller, runner, runner group, repository access, label, MIN, per-runner limit, deployment, development, or production state.
  • The first live consumer proof will be one separately authorized downstream consumer experimental Fast matrix.
  • Initial pilot MAX=1 remains a hard gate.
  • Rollback restores only the prior host-local MAX from one protected backup.
  • No production or deployment capability is involved.

Validation

  • RED: focused test failed because the separate validator did not exist.
  • GREEN: scripts/test-capacity-preflight.sh passes.
  • git diff --check passes.
  • Bash syntax passes for all project scripts.
  • Planner tests: 7/7 pass.
  • Public configuration policy tests: 12/12 pass.
  • Secret-pattern scan passes.
  • Pilot preflight source is unchanged.
  • No unrestricted Docker prune exists.
  • Full inert build validation reaches the Docker build step but cannot complete on the local Hermes host because Docker is not installed; PR CI is the authoritative Docker-capable validation.

Closes #30

@Nickfost

Copy link
Copy Markdown
Member Author

@codex review

Please review the current head with particular attention to:

  • preserving the strict one-runner pilot gate;
  • fail-closed resource accounting;
  • idle/drain requirements;
  • secret-safe output;
  • controller recreation and rollback;
  • whether the procedure is sufficient for a real MAX=2 proof.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5cbbdabd0d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/CAPACITY-PROMOTION.md Outdated
Comment thread scripts/capacity-preflight.sh Outdated
@Nickfost

Copy link
Copy Markdown
Member Author

@codex review

Please re-review the current PR head after the fixes for:

  • stale shell-variable precedence during promotion and rollback;
  • project-labeled container, volume, and network residue;
  • ShellCheck SC1007.

Please retain particular attention to the strict MAX=1 pilot gate, fail-closed MAX=2 accounting, secret-safe output, controller recreation, and rollback.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dd8043dac3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/capacity-preflight.sh
Comment thread scripts/capacity-preflight.sh
@Nickfost

Copy link
Copy Markdown
Member Author

@codex review

Please re-review the current PR head after bounding the first post-pilot target to exactly MAX=2 and disabling inherited xtrace before all configuration/controller inspection. Please also verify the previous Compose-environment and project-resource residue fixes remain correct.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: afab5e207d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/capacity-preflight.sh
@Nickfost

Copy link
Copy Markdown
Member Author

@codex review

Please re-review the current head after adding fail-closed generic Docker Compose residue detection for containers, volumes, and networks. Please verify the accepted controller project exception is narrow and all earlier MAX=2, xtrace, Compose-environment, and custom-label residue fixes remain correct.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 109e0bed2a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/capacity-preflight.sh
@Nickfost

Copy link
Copy Markdown
Member Author

@codex review

Please re-review the current head after narrowing the Compose exception to the exact committed controller container and default network, with zero named volumes. Please verify same-project rogue resources and all earlier findings remain closed.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e98bb1a203

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/CAPACITY-PROMOTION.md Outdated
@Nickfost

Copy link
Copy Markdown
Member Author

@codex review

Please re-review the current head after making rollback pilot preflight and healthcheck source the restored file in clean environments. Please verify all earlier findings remain closed and the current head is safe to merge.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 115101a019

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Nickfost
Nickfost merged commit 3d11843 into main Jul 17, 2026
1 check passed
@Nickfost
Nickfost deleted the hermes/post-pilot-capacity-promotion branch July 17, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P1][Fleet] Add and prove post-pilot two-runner capacity promotion

1 participant