docs(security): sync .bestpractices.json to live passing state (drop vestigial _url keys)#123
Merged
Merged
Conversation
The live OpenSSF record (https://www.bestpractices.dev/projects/12646.json) is now passing (badge_level=passing, 100%). Reconcile the repo golden source to match the authoritative live schema: - Drop 29 vestigial per-criterion <crit>_url keys. The live record has NO per-criterion URL field (only the top-level homepage_url / repo_url / badge_url / project_page_url), confirming the URL must live inline in the justification -- which it now does for all url-required criteria (PR #122). The 4 real top-level URL metadata fields are kept. - Correct _comment to document the inline-URL reality (no separate per-criterion URL field) and drop the false "<key>_url where required" clause. - Simplify report_archive link to /issues to match the live passing value. - Refresh self_assessment_date to 2026-06-18. Kept our richer project-specific justifications rather than overwriting them with bestpractices.dev's auto-generated boilerplate (and a stray OSPS tag); both validate and the badge stays passing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LDQVJrixs2nJoea67a8pEG
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reconcile the repo
.bestpractices.jsongolden source against the live passingOpenSSF record (
https://www.bestpractices.dev/projects/12646.json, nowbadge_level=passing, 100%).<crit>_urlkeys. The live record has noper-criterion URL field — only the top-level
homepage_url/repo_url/badge_url/project_page_url(all kept). This settles it: the URL must be inline in thejustification, which it is for all 8 url-required criteria (PR docs(security): embed required URLs inline in .bestpractices.json justifications #122).
_commentto document that (no separate per-criterion URL field).report_archivelink simplified to/issuesto match the live value.self_assessment_date→ 2026-06-18.Deliberately not done
Did not overwrite our richer, project-specific justifications with
bestpractices.dev's auto-generated boilerplate (e.g. "Some documentation basics
file contents found.") or re-introduce the stray
[osps_br_03_02]tag the livedelivery_mitmentry still carries. Both forms validate; ours are better and thebadge stays passing. (A literal byte-for-byte mirror is available on request.)
Verification
8 url-required justificationsall still carry an inlinehttps://link.per_crit_url=0, 4 top-level URL metadata fields retained,level=passing.3 insertions, 32 deletions.🤖 Generated with Claude Code
https://claude.ai/code/session_01LDQVJrixs2nJoea67a8pEG