workspace concretize: define missing variables and expand software specs - #1761
Open
chinglung880218 wants to merge 1 commit into
Open
Conversation
chinglung880218
force-pushed
the
fix-concretize-missing-variables
branch
2 times, most recently
from
September 3, 2026 00:38
edec350 to
bc4a89a
Compare
Fixes an issue where running 'ramble workspace concretize' failed with a
schema ValidationError (CommentedMap is not of type 'string') when compiler
specs contained variable templates (e.g., {system_compiler_spec}).
Key changes:
- Call app_inst.define_missing_variables() during concretize to ensure
system, platform, and modifier variables are registered in app_inst.variables.
- Add _expand_software_spec() to expand template variables in SoftwareSpec
instances (pkg_spec, compiler_spec, compiler) for compiler definitions.
- Add regression unit tests with mock application and modifier in
workspace_concretize.py.
Signed-off-by: Ching-Lung Hsu <chinglunghsu@google.com>
chinglung880218
force-pushed
the
fix-concretize-missing-variables
branch
from
September 3, 2026 04:00
bc4a89a to
029eb60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where running 'ramble workspace concretize' failed with a schema ValidationError (CommentedMap is not of type 'string') when compiler or software specs contained variable templates (e.g., {system_compiler_spec}).
Key changes: