Add tests to verify e2e analyze caching behavior - #1755
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds a new test suite in test_workspace_analyze.py to verify workspace analysis features, including FOM filtering and results caching. The review feedback recommends replacing time.sleep calls with explicit timestamp modifications using os.utime to prevent test flakiness on slow CI environments and low-resolution filesystems, which also allows for the removal of the unused time module import.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds a new test suite test_workspace_analyze.py to verify workspace analysis filtering and results caching behavior, including cache invalidation scenarios. The review feedback suggests improving the robustness of the cache invalidation tests by setting the cache file's timestamp to the past rather than setting the log file's timestamp to a future time, which can be flaky depending on filesystem precision.
Ramble Performance Test MetricsResults produced with commit: 5523be2
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1755 +/- ##
===========================================
+ Coverage 94.07% 94.09% +0.01%
===========================================
Files 370 371 +1
Lines 37424 37517 +93
===========================================
+ Hits 35207 35301 +94
+ Misses 2217 2216 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Bob <robertbird@google.com>
Signed-off-by: Bob <robertbird@google.com>
This augments the existing tests by representing hte e2e workflow