Migrate unit tests to a dedicated cloud build private pool - #1750
Migrate unit tests to a dedicated cloud build private pool#1750linsword13 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the Google Cloud Build and Terraform configurations to consolidate worker pools under a unified private pool (n2d_pool). Feedback highlights two main issues: first, changing the physical name of the worker pool resource will force a resource replacement (destroy and recreate) in GCP, which can be avoided by keeping the physical name while refactoring the Terraform address; second, setting the default value of _WORKER_POOL to an empty string in the unit tests configuration will cause Cloud Build validation errors if the substitution is not overridden.
d18d31e to
ddd8f2f
Compare
Ramble Performance Test MetricsResults produced with commit: 3c11668
|
ddd8f2f to
fcdf939
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request configures a private N2D worker pool in the southamerica-west1 region for Ramble unit tests and updates the Cloud Build triggers to use this pool along with a repository connection config. Feedback on these changes highlights that the repository connection strings hardcode the owner and repository name, which bypasses existing configuration variables. Additionally, pulling builder images across regions from us-central1 to southamerica-west1 may introduce latency and egress costs, and defaulting the _WORKER_POOL substitution to an empty string could trigger Cloud Build validation failures.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1750 +/- ##
========================================
Coverage 94.04% 94.04%
========================================
Files 370 370
Lines 37331 37331
========================================
Hits 35109 35109
Misses 2222 2222 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fcdf939 to
ab11a70
Compare
We've been seeing more internal errors from the regional (us-central1) default pool, so migrating to use a private pool for these tests. We pick southamerica-west1 as we have the quota. Signed-off-by: Lin Guo <linsword13@gmail.com>
ab11a70 to
3c11668
Compare
We've been seeing more internal errors from the regional (us-central1) default pool, so migrating to use a private pool for these tests. We pick southamerica-west1 as we have the quota.