Skip to content

Migrate unit tests to a dedicated cloud build private pool - #1750

Open
linsword13 wants to merge 1 commit into
Ramble-Project:developfrom
linsword13:pr-test-private-pool
Open

Migrate unit tests to a dedicated cloud build private pool#1750
linsword13 wants to merge 1 commit into
Ramble-Project:developfrom
linsword13:pr-test-private-pool

Conversation

@linsword13

@linsword13 linsword13 commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

We've been seeing more internal errors from the regional (us-central1) default pool, so migrating to use a private pool for these tests. We pick southamerica-west1 as we have the quota.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Google Cloud Build and Terraform configurations to consolidate worker pools under a unified private pool (n2d_pool). Feedback highlights two main issues: first, changing the physical name of the worker pool resource will force a resource replacement (destroy and recreate) in GCP, which can be avoided by keeping the physical name while refactoring the Terraform address; second, setting the default value of _WORKER_POOL to an empty string in the unit tests configuration will cause Cloud Build validation errors if the substitution is not overridden.

Comment thread share/ramble/cloud-build/terraform/triggers/worker_pool.tf Outdated
Comment thread share/ramble/cloud-build/ramble-pr-unit-tests.yaml
@linsword13
linsword13 force-pushed the pr-test-private-pool branch from d18d31e to ddd8f2f Compare August 26, 2026 17:08
@ramble-pr-bot

ramble-pr-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

Ramble Performance Test Metrics

Results produced with commit: 3c11668

Test Name Outcome Duration (s) Most Recent Run (s) Last 5 Avg (s)
test_analyze_large_file passed 2.0809 2.0776 (2d42cdb) 2.0633
test_large_template_expansion passed 1.2312 1.1994 (2d42cdb) 1.1989
test_many_experiments passed 24.0619 23.2386 (2d42cdb) 23.6468
test_many_objects_defaults passed 13.6165 12.1959 (2d42cdb) 12.5012
test_matrix_filter_perf passed 1.1793 1.0590 (2d42cdb) 1.0757

@linsword13
linsword13 marked this pull request as draft August 26, 2026 18:15
@linsword13
linsword13 force-pushed the pr-test-private-pool branch from ddd8f2f to fcdf939 Compare August 26, 2026 19:29
@linsword13 linsword13 changed the title Move unit tests into the n2d private pool Migrate unit tests to a dedicated cloud build private pool Aug 26, 2026
@linsword13

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures a private N2D worker pool in the southamerica-west1 region for Ramble unit tests and updates the Cloud Build triggers to use this pool along with a repository connection config. Feedback on these changes highlights that the repository connection strings hardcode the owner and repository name, which bypasses existing configuration variables. Additionally, pulling builder images across regions from us-central1 to southamerica-west1 may introduce latency and egress costs, and defaulting the _WORKER_POOL substitution to an empty string could trigger Cloud Build validation failures.

Comment thread share/ramble/cloud-build/terraform/triggers/pr_unit_tests.tf Outdated
Comment thread share/ramble/cloud-build/terraform/triggers/codecov.tf Outdated
Comment thread share/ramble/cloud-build/terraform/triggers/codecov.tf Outdated
Comment thread share/ramble/cloud-build/ramble-pr-unit-tests.yaml
Comment thread share/ramble/cloud-build/ramble-pr-unit-tests.yaml
@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.04%. Comparing base (279e771) to head (ab11a70).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1750   +/-   ##
========================================
  Coverage    94.04%   94.04%           
========================================
  Files          370      370           
  Lines        37331    37331           
========================================
  Hits         35109    35109           
  Misses        2222     2222           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@linsword13
linsword13 force-pushed the pr-test-private-pool branch from fcdf939 to ab11a70 Compare August 26, 2026 20:14
@linsword13
linsword13 marked this pull request as ready for review August 26, 2026 21:06

@rfbgo rfbgo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcoapp recheck

We've been seeing more internal errors from the regional (us-central1) default pool, so migrating to use a private pool for these tests. We pick southamerica-west1 as we have the quota.

Signed-off-by: Lin Guo <linsword13@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants