Add new simplify command - #1661
Draft
rfbgo wants to merge 16 commits into
Draft
Conversation
rfbgo
marked this pull request as draft
July 16, 2026 17:57
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new simplify command for the Ramble framework, designed to identify and optionally remove unused variables, inputs, executables, and compilers from definition files, as well as detect broken references. The review feedback highlights several areas for improvement, including replacing broad exception handling with specific exceptions to improve debugging, optimizing the instantiation of the Keywords class to avoid redundant work, and refactoring duplicated cache-resetting logic in the test suite into a reusable helper function.
Ramble Performance Test MetricsResults produced with commit: 8d248b4
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1661 +/- ##
===========================================
+ Coverage 93.94% 93.98% +0.03%
===========================================
Files 367 370 +3
Lines 36605 37925 +1320
===========================================
+ Hits 34389 35642 +1253
- Misses 2216 2283 +67 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rfbgo
force-pushed
the
simplify
branch
5 times, most recently
from
July 20, 2026 22:21
7d03ee3 to
86ca51f
Compare
rfbgo
marked this pull request as ready for review
August 4, 2026 17:43
rfbgo
marked this pull request as draft
August 12, 2026 14:23
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…mmand - Wrap when() and default_args() yield calls in try/finally blocks to ensure contexts are cleanly popped even if directives raise exceptions. Add DirectiveMeta._reset_staging() and invoke it upon module load failures in repository.py to prevent condition leakage across object definitions. - Consolidate repetitive template extraction and reference validation across executables, variables, environment variables, inputs, figures of merit, and success criteria into iter_object_template_strings(). Unify unreferenced item counting in count_unreferenced_items() and map directives with DIRECTIVE_CATEGORIES. - Support refactoring and moving unused parent variables to inheriting subclasses.
rfbgo
force-pushed
the
simplify
branch
2 times, most recently
from
August 17, 2026 22:40
ed9e3ad to
26caa5b
Compare
rfbgo
force-pushed
the
simplify
branch
2 times, most recently
from
August 19, 2026 16:14
6bb6959 to
eeddb4c
Compare
rfbgo
commented
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.