Set up automated checks for unexpected DLL imports#448
Merged
Conversation
Could instead do it with Unix tools, but this way works OOB on Win32. Should also be easier to customize this later to perform other checks.
Just cmd.exe things (it's cosmetic, but wasn't printed, anyway).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably can't eliminate most of the Win32 imports, but at least this should raise awareness when adding new dependencies.
Unfortunately doesn't cover optional dependencies, which could be slightly annoying if more of those need to be used later.