Skip to content

Fix CMake Install - #311

Merged
Raffaello merged 5 commits into
masterfrom
libs-install
Jul 27, 2026
Merged

Fix CMake Install#311
Raffaello merged 5 commits into
masterfrom
libs-install

Conversation

@Raffaello

@Raffaello Raffaello commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • New Features

    • Updated packaging so builds using spdlog include the required fmt and spdlog components.
    • Ensured installed library exports are consistently available to downstream projects.
  • Bug Fixes

    • Enabled spdlog support explicitly in the MSYS2 CI build configuration.
  • Chores

    • Bumped the project version from 0.19.6 to 0.19.7.
    • Improved build configuration handling for the fmt dependency.

@Raffaello Raffaello self-assigned this Jul 27, 2026
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@Raffaello, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 54 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 65065a99-5b76-4169-b717-4df420573188

📥 Commits

Reviewing files that changed from the base of the PR and between c80f728 and 38af993.

📒 Files selected for processing (4)
  • .github/workflows/ci-linux.yml
  • .github/workflows/ci-msys2.yml
  • .github/workflows/ci-windows.yml
  • hyper-sonic-drivers/CMakeLists.txt

Walkthrough

The changes update CMake packaging and export behavior, propagate fmt_SOURCE_DIR, bump the project version to 0.19.7, and enable SPDLOG explicitly in the MSYS2 CI configuration.

Changes

CMake packaging and CI

Layer / File(s) Summary
Dependency propagation and packaging exports
libs/CMakeLists.txt, hyper-sonic-drivers/CMakeLists.txt
fmt_SOURCE_DIR is propagated to the parent scope, while conditional installation and export handling is consolidated for fmt, spdlog, and ${LIB_NAME}.
Version metadata and MSYS2 configuration
CMakeLists.txt, .github/workflows/ci-msys2.yml
The project version changes to 0.19.7, and MSYS2 configuration explicitly enables USE_SPDLOG=ON; the matrix formatting is also adjusted.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Poem

A bunny finds fmt in its burrow so bright,
SPDLOG hops into builds overnight.
Exports gather neatly, versions take flight,
MSYS2 follows the new path just right.
“CMake carrots for all!” says the rabbit with delight.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is clearly related to the main changes, which focus on CMake install/export behavior and packaging fixes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch libs-install

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Raffaello Raffaello added bug Something isn't working ci continus integration labels Jul 27, 2026
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@Raffaello
Raffaello marked this pull request as ready for review July 27, 2026 10:57
coderabbitai[bot]

This comment was marked as resolved.

@Raffaello
Raffaello merged commit 0a91234 into master Jul 27, 2026
16 checks passed
@Raffaello
Raffaello deleted the libs-install branch July 27, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci continus integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant